Use currently selected remote DB when Variant Analysis is run#1838
Merged
norascheuch merged 5 commits intomainfrom Dec 7, 2022
Merged
Use currently selected remote DB when Variant Analysis is run#1838norascheuch merged 5 commits intomainfrom
norascheuch merged 5 commits intomainfrom
Conversation
norascheuch
force-pushed
the
charis-nora/run-mrva-against-selected-db
branch
from
cfeb753 to
651ac08
Compare
norascheuch
force-pushed
the
charis-nora/run-mrva-against-selected-db
branch
from
651ac08 to
728f801
Compare
charisk
approved these changes
Dec 7, 2022
Contributor
charisk
left a comment
charisk
left a comment
There was a problem hiding this comment.
Great work! Love seeing all the tests too!
charisk
reviewed
Dec 7, 2022
Contributor
Author
|
Tested with and without feature flag ✅ |
charisk
reviewed
Dec 7, 2022
| const dbManager = { | ||
| getSelectedDbItem: jest.fn(() => undefined), | ||
| } as any as DbManager; | ||
| const dbManager = setUpDbManager(undefined) as any as DbManager; |
Contributor
There was a problem hiding this comment.
Your setUpDbManager function can do the casting so you don't have to do it every time. The function should have a return type of DbManager.
norascheuch
force-pushed
the
charis-nora/run-mrva-against-selected-db
branch
from
0ece13e to
323862a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running a MRVA while the new Query Run Experience feature flag is enabled we want to use the new DB panel to inform on which repositories to run the query.
Checklist
ready-for-doc-reviewlabel there.